On 21/03/2016 20:19, "Lerner, Dave" <[email protected]> wrote:
>Belen, Elliot, >I will rebase on toaster-next and send out a V3 set. >All patches will be marked V3. Thanks, Dave. Just for the record, to test I checked out this branch dlerner/9121-delete-dependent-package-tree Now, I must have done something wrong, since it's working for the 2 of you. I'll try again when v3 comes. Cheers Belén >-Dave > >> -----Original Message----- >> From: Smith, Elliot [mailto:[email protected]] >> Sent: Monday, March 21, 2016 3:07 PM >> To: Lerner, Dave >> Cc: BARROS PENA, BELEN; [email protected] >> Subject: Re: [Toaster] [V2 review-request] show and delete recursive >>list of reverse >> dependencies >> >> Hi Dave. >> >> >> On 21 March 2016 at 19:37, Lerner, David M (Wind River) >><[email protected]> >> wrote: >> >> >> Sorry you had problems. Are you certain that you applied all 3 >>patches? Your >> results indicate that the customrecipe.js was not replaced with the new >>v2 patch that >> was part of the 4-part email (3 patches and the v2 of the review >>request). >> >> >> >> I checked out your branch and used that, rather than putting the >>patches on top of >> toaster-next. (As you pointed out, it needs rebasing, but I didn't do >>that.) >> >> I managed to follow the instructions in your cover letter and got the >>results you >> outlined (though for some reason my sato has 608 packages, not 607, and >>mysato has 568). >> >> So it does seem to work correctly for me. >> >> Belen, if you are putting Dave's patches on top of toaster-next, that >>might be causing >> your problem (I don't think you mentioned how you were testing). >> >> Dave, if you rebase on toaster-next, I am happy to give it another try >>tomorrow and do >> another code review. >> >> Thanks. >> Elliot >> >> >> >> >> As the attached 3 jpgs indicate, I get the expected results, >>verified just now by >> doing the following: >> - checked-out my local dlerner/9121-delete-dependent-package-tree >>branch again, >> - wiped out the build and poky/_toaster* poky/_meta* directories, >> - rebuilt core-image-sato and customized it >> - looked at openssl on a remove package and it looked fine, jpg >>attched >> - customised core-image-minimal >> - added atk >> - looked at remove libprce and it looks fine, jpg attached. >> >> Here is how I verified that the email and the poky-contrib branch >>are correct. >> - I saved the patches 0001,2,3 from the emails that I sent >> - then I diff'd those against a new set of formatted patches and >>the diffs matched >> (except for manual insertions of the V2) >> - then, just to make sure that the format-patch command wasn't >>goofed up (in my >> script) I ran 'patch -R --dry-run -p1 ' on each of the patches and they >>applied cleanly. >> >> My poky-contrib branch was force-updated and I get this today: >> toaster> git status >> On branch dlerner/9121-delete-dependent-package-tree >> Your branch is up-to-date with >>'poky-contrib/dlerner/9121-delete-dependent-package- >> tree'. >> >> It's been sufficiently long since my original commits that I may >>need to rebase >> against toaster-next. I was reluctant to rebase to toaster-next last >>week after I heard >> at the Wednesday conference call that toaster-next hung on a build. >>That seems to have >> been fixed so if you want a V3 rebased, let me know. >> - Dave >> >> ________________________________________ >> From: Barros Pena, Belen [[email protected]] >> Sent: Monday, March 21, 2016 11:52 AM >> To: Lerner, Dave; [email protected]; SMITH, ELLIOT >> Subject: Re: [Toaster] [V2 review-request] show and delete >>recursive list of >> reverse dependencies >> >> >> On 17/03/2016 22:01, "[email protected] on behalf >>of Dave >> Lerner" <[email protected] on behalf of >> [email protected]> wrote: >> >> > >> >Target Branch: toaster-next master >> >Contrib Branch: >>poky-contrib/dlerner/9121-delete-dependant-package-tree >> >Defect: 9121 >> >Summary: Show and delete recurive list of reverse dependencies >> >> In this version the text of the reverse dependencies dialog seems >>to be >> cut. The first sentence before the list of packages says: "in >>your image >> on libcrypto". The last sentence after the list of packages says: >>"In >> order to remove libcrypto, you must remove as well". So there >>seems to be >> some text missing. >> > >> >Comment: Version 2 patch set per comments from Belen and Elliot. >> > Only 1/3 and 3/3 patches are changed, but 2/3 is >>included. >> > >> >Commit >> >------ >> >c801079 toaster: get all dependants for pkg for removal >> >327ada3 toaster: new customise package-remove modal dlg >> >7542b8a toaster: show full list of dependants to remove >> > >> > .../toaster/toastergui/static/js/customrecipe.js | 72 >>+++++++++++++++-- >> > .../toaster/toastergui/templates/customrecipe.html | 5 +- >> > bitbake/lib/toaster/toastergui/views.py | 91 >> >+++++++++++++++++++--- >> > 3 files changed, 148 insertions(+), 20 deletions(-) >> > >> > >> >Test Cases: >> >[V2] denotes additional test for version 2, changes per Belen's >>comments. >> > >> >SETUP: >> >----- >> >Start toaster with empty build directory, sstate-cache >> >Create a new project, 'myproject' >> >Build core-image-sato >> > >> >CASE Remove dependant package that was part of original base >>image >> >>>------------------------------------------------------------------ >> >Create new custom image on core-image-sato, named mysato >> >Remove libcrypto >> > Verify that "39 packages will be removed" are reported and >>that the >> > packages are unique and in alpha order >> > [V2] Verify that the notification shows >> >"You have removed libcrypto and its 39 reverse dependencies: >> >gst-player-bin, gstreamer1.0-plugins-bad-dtls, >> >gstreamer1.0-plugins-bad-meta, gstreamer1.0-plugins-bad-opengl, >> >libegl-mesa and 34 more" >> >> When I remove libcrypto, the notification is missing the >>dependency >> information. It says only: "You have removed 1 packages from >>sato-belen: >> libcrypto". The reverse dependencies seem to have been removed >>though >> (they show the 'add package' button and the new number of packages >> installed has been reduced by the number of packages removed). >>I've >> attached a screenshot. >> >> > >> >Build mysato >> >Click on the All Builds mysato: >> > Verify Images : Packages included field shows 40 packages >>less than if >> > you look at All Builds | core-image-sato (eg 567 vs 607) >> > >> >CASE Add back a root dependency (Issue sent in email Mar9) >> >---------------------------------------------------------- >> >Open custom image mysato >> >Add libcrypto back >> >Build >> >Click All Projects | Custom Images | mysato >> > Verify libcrypto 'looks' added: that the entry shows "remove >>package" >> > >> >CASE Test no interference removing from a 2nd custom image in >>project >> >>>---------------------------------------------------------------------- >> >New custom-image based on core-image-sato 'myminimal' >> >Build it >> >Add atk which is dependant on glib-2.0, libffi, libpcre (bash >>appears but >> >this >> >is busybox system, so don't think that dependency will apply - >>maybe bug >> >unrelated to this work). >> >Build myminimal again. >> >Verify that atk, libffi, libpcre, glib-2.0 have files in the >>file system >> >For custom image myminimal, enter libpcre, remove package >> > Verify modal dlg notes libpcre atk and glib-2.0 will be >>removed Remove >> >Build >> > Verify atk, glib2.0 and libpcre are removed. >> > >> >CASE Test button notifications and banner on removal for package >>w/ >> >dependants >> >>>------------------------------------------------------------------------ >>>-- >> >---- >> >To minimal, add openssl-staticdev which indirectly will bring in >>libssl >> >Build >> >Verify that libssl, openssl, openssl-dev are added >> >On minimal, enter "openssl" to see a set of matching packages. >> >REmove libssl >> > Verify modal dialog reports both the direct and indirect >>dependants >> > openssl, openssl-dev, and openssl-staticdev, will be >>removed. >> >> >> I tested this with openssl (openssl-staticdev was missing from my >>list). >> Adding openssl brought in libssl. When you click remove package >>for libssl >> you get the dialog saying that openssl will be removed as well, >>but when >> you click 'remove all', openssl is not removed: it still shows >>the 'remove >> package' button. However, when I filter the list to show only the >>packages >> added, openssl is not on the list. This was a bit strange, so I've >> recorded it so that you will believe me ;) The video is here >> >> >>https://drive.google.com/file/d/0B1KD45-8S-9FRF8td29abHNrbHc/view?usp=sha >>ri >> ng >> >> >Click Remove all >> > Verify the buttons for openssl (an others that you see on >>screen) >> >report: >> > "4 packages removed" >> > Verify that the banner says: >> > "You have removed 4 packages from minimal: libssl and >>it's 3 >> >dependantso Verify that buttons transition to Add Package. >> > >> >[V2] CASE Remove package that has only has 1 dependant >> >------------------------------------------------------ >> >To minimal, add back openssl-staticdev >> >Build >> >Select openssl-dev and remove the package. >> > Verify that syntax for 1 rev-dep is appropriate on modal dlg. >> > Remove the 2 packages >> > Verify that syntax for 1 reverse dependency on main page >>notifiation. >> >> Same problem with this one: removing openssl-dev doesn't seem to >>remove >> openssl-staticdev. But when I search again for openssl-staticdev, >>the >> button has been updated and changed 'add package'. >> >> Cheers >> >> Belén >> >> > >> >-- >> >_______________________________________________ >> >toaster mailing list >> >[email protected] >> >https://lists.yoctoproject.org/listinfo/toaster >> >> >> >> >> >> >> -- >> >> Elliot Smith >> Software Engineer >> Intel Open Source Technology Centre -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
