Hello Dave. I tried to merge your patch into toaster-next today, but it unfortunately wouldn't apply cleanly.
Could you please rebase? As it's a single commit, I'm happy to take it from the tip of a branch rather than you having to re-submit it. Thanks. Elliot On 6 April 2016 at 15:47, Smith, Elliot <[email protected]> wrote: > On 6 April 2016 at 15:42, Lerner, Dave <[email protected]> wrote: > >> It's been a while, but as I recall both the HTML5 validator I used and >> the toaster coding standards mandate that element ids must be unique on a >> page. The page loads both sections, with and without data, so reusing the >> same element id as I did in the first pass failed the validation test (and >> standards). >> > > Right, that makes sense. I didn't realise both inputs would be visible at > the same time (I should have paid more attention to Belen's design). > > (Though, as an aside, issues like this are exactly why I don't use IDs and > prefer data-* attributes instead.) > > I will review it again. > > Thanks, > Elliot > > >> Dave >> >> ------------------------------ >> *From:* [email protected] [ >> [email protected]] on behalf of Smith, Elliot [ >> [email protected]] >> *Sent:* Wednesday, April 06, 2016 9:18 AM >> *To:* Lerner, Dave >> *Cc:* Belen Barros Pena (Intel); [email protected] >> *Subject:* Re: [Toaster] [toaster] [review-request] 9154: fixes for >> customimage details 'no package found' >> >> Sorry I've only just got to this, Dave. >> >> The code generally looks fine. >> >> My only question is why you've added an element with a different id to >> hold the alternative no results area. Is there any reason it can't have the >> same id="no-package-results" as the standard area? >> >> Similarly, the input element could have the >> name "#new-search-input-"+ctx.tableName so that its content is reset by the >> existing code in table.js. >> >> This could (I think) remove the need for any changes to table.js. >> >> Elliot >> >> On 16 March 2016 at 17:29, Dave Lerner <[email protected]> wrote: >> >>> >>> Branch: toaster-next, master >>> Defect: 9154 >>> Summary: Fixes when search for customimage packages has no results. >>> >>> jshint: done >>> html5 validation: done >>> >>> Test cases and expected results >>> ------------------------------- >>> Setup >>> ----- >>> Build a custom image >>> >>> Static Text >>> ----------- >>> Select the custom image and enter an unknown package like "xxxxx". >>> Verify that the static text matches the spec with caveats below. >>> 1. The spec shows a different header for both the no results >>> and the results page. The spec was interpretted as being >>> out-of-date >>> with current implemenation, and the well "About package..." was >>> assumed to be the current implementation replacment since it >>> shows >>> the packages included and other data. >>> 2: The spec "search query" was assumed to be a place holder in >>> the design doc for a string that was the last unsucessful 'search >>> query'. >>> Verify that the text field has the unmatched string xxxxx >>> >>> All buttons - x, search, search all packages, search recipes >>> ----------------------------------------------------------------- >>> X button: >>> click the x icon >>> Verify that the text input is cleared. >>> Verify that the X icon is cleared. >>> Verify "Search Add | Remove packages" placeholder in text field. >>> >>> Search: >>> enter openssl >>> click search >>> Verify back to customised screen with packages matching 'openssl' >>> >>> On customise image main page, append abc to openssl and click search >>> Verify back to the No packages found screen >>> On NO packages found page, change text from opensslabc to opensslxyz >>> click search >>> Verify still on No Packages screen >>> >>> Search all packages: >>> On the same 'opensslxyz' No packages found page, >>> click Search all packages >>> Verify back to unfiltered customised image page >>> >>> Recipes: >>> Enter helloworld, click search >>> On 'No packages found' page, click the hyperlink "searching the list of >>> recipes" >>> Verify that the software recipes page appears. >>> >>> >> >> >> -- >> Elliot Smith >> Software Engineer >> Intel Open Source Technology Centre >> > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > -- Elliot Smith Software Engineer Intel Open Source Technology Centre
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
