On 18/04/2016 12:53, "sujith h" <[email protected]> wrote:
> > >On Mon, Apr 18, 2016 at 5:09 PM, sujith h ><[email protected]> wrote: > >Hi Belen, > >On Mon, Apr 18, 2016 at 4:57 PM, Barros Pena, Belen ><[email protected]> wrote: > > > >On 14/04/2016 14:57, "[email protected] on behalf of sujith >h" <[email protected] on behalf of >[email protected]> >wrote: > >> >> >>On Thu, Mar 31, 2016 at 8:39 PM, Michael Wood >><[email protected]> wrote: >> >>Done a quick review on IRC we'll try to convert the project page from >>doing a POST directly to the view to use the ajax+ReST like approach we >>have else where (e.g. custom image recipes). >> >> >>Michael had once again reviewed my patch set today and I had trimmed down >>my code: >> >>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toas >>t >>er-unique-projectname > > >Belen, can you check the branch again. I have deleted the branch and >created it again. And now the error doesn't come. Yep: error is gone now, so I was able to try it :) I've found a couple of small issues with the behaviour and the styling: * we need to apply the .control-group and .error classes to the fieldset containing the project name when the error message comes up, so that the label and input field look red like the message. That will match what we do in the rest of Toaster, and will help people realise there is an issue with the name they typed. * Michael tells me we are using the "change" event, and recommends we use "blur" instead * Finally, the error message should go away the moment the error condition disappears, i.e. when users change the name. It needs to work exactly like the validation for the layer name field in the import layer page. To see it, create a project in Toaster with the master release, then click on "import layer", then type "meta-oe" in the layer name and tab or click away from the text field. A note will come up saying that a layer with that name already exists. Then add / remove something from the layer name: on key up the message will go away. This is exactly the behaviour we need to use in the case of the project name, making things nicely consistent across the UI Finally, I am afraid my design is incomplete: you can change the name of an existing project, so we need to validate the name is unique in that case as well. I am really sorry: I should have noticed this. Luckily Michael realised for me :) I've updated the design document attached to the bug https://bugzilla.yoctoproject.org/show_bug.cgi?id=7005 It now includes a second page explaining the missing bits. Once we have things working in the new project page, hopefully it won't be too hard to extend the functionality to the project configuration pages. Thanks! Belén > > > > > >Thanks, > >Sujith H > > > > > >Thanks! > >Belén > > >> >><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toa >>s >>ter-unique-projectname> >> >> >> >> >>Michael >> >>On 30/03/16 16:04, sujith h wrote: >> >>Hi, >> >>I have posted my changes for bug 7005: >>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toas >>t >>er-unique-projectname >><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toa >>s >>ter-unique-projectname> ( The top 2 commits ). >> >>This patch set helps user not to have same project names for toaster. >> >>Thanks, >>Sujith H >> >>-- >>സുജിത് ഹരിദാസന് >>Bangalore >><Project>Contributor to KDE project >><Project>Contributor to Yocto project >>http://fci.wikia.com/wiki/Anti-DRM-Campaign >><Blog> http://sujithh.info >>C-x C-c >> >> >> >> >> >> >> >>-- >>_______________________________________________ >>toaster mailing list >>[email protected] >>https://lists.yoctoproject.org/listinfo/toaster >> >> >> >> >> >> >>-- >>സുജിത് ഹരിദാസന് >>Bangalore >><Project>Contributor to KDE project >> >><Project>Contributor to Yocto project >> >>http://fci.wikia.com/wiki/Anti-DRM-Campaign >><Blog> http://sujithh.info >> >>C-x C-c >> >> >> >> >> >> >> > > > > > > > > > > > >-- >സുജിത് ഹരിദാസന് >Bangalore ><Project>Contributor to KDE project > ><Project>Contributor to Yocto project > >http://fci.wikia.com/wiki/Anti-DRM-Campaign ><Blog> http://sujithh.info > >C-x C-c > > > > > > > > > > > > > > > > >-- >സുജിത് ഹരിദാസന് >Bangalore ><Project>Contributor to KDE project > ><Project>Contributor to Yocto project > >http://fci.wikia.com/wiki/Anti-DRM-Campaign ><Blog> http://sujithh.info > >C-x C-c > > > > > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
