On 23/05/2016 21:44, "[email protected] on behalf of
Michael Wood" <[email protected] on behalf of
[email protected]> wrote:

>Port the main build tables in the build analysis area to ToasterTables.
>
>This is the table for Installed packages, Tasks, Recipes, Packages, Time,
>CPU usage and Disk I/O

This is looking good. I've only found some small issues in the packages
installed table. Here they come:

* When you load the table, the sorting by "Package" is not working
properly. The first package shown is
"packagegroup-core-full-cmdline-dev-utils", but it should be "acl"

* The package name should be a link to the package installed details page

* The dependencies and reverse dependencies popups are missing the links.
The package name in the title should link to the 'dependencies' or
'reverse dependencies' tab in the package installed details page. Each
package listed in the popovers should be a link to the corresponding
package installed details page

And to finish up, a question / comment: "Approx size" and "Installed size"
seem to show always the same figure. Are we sure they are different
things? If they are different things but are always the same, is it worth
showing both?

Thanks!

Belén

>
>Michael Wood (7):
>  toaster: ToasterTable widget add an 'a' to Name in Exception class
>  toaster: port table for Built packages to ToasterTable
>  toaster: port Built recipes table to toastertables
>  toaster: port Task tables to ToasterTables widget
>  toaster: port Installed packages table to ToasterTable
>  toaster: table.js Add the ability to highlight a particular row
>  toaster: tests Add new build tables to tests
>
> bitbake/lib/toaster/toastergui/buildtables.py      | 563
>++++++++++++++++++
> .../fixtures/toastergui-unittest-data.xml          |  91 ++-
> bitbake/lib/toaster/toastergui/static/js/table.js  |   9 +
> bitbake/lib/toaster/toastergui/tables.py           |  10 +-
> .../toastergui/templates/basebuildpage.html        |  26 +-
> .../lib/toaster/toastergui/templates/bpackage.html | 108 ----
> .../toastergui/templates/builddashboard.html       |   4 +-
> .../templates/buildinfo-toastertable.html          |  25 +
> .../toaster/toastergui/templates/buildtime.html    |   4 -
> .../lib/toaster/toastergui/templates/recipes.html  | 113 ----
> .../templates/snippets/gitrev_popover.html         |   8 +
> .../lib/toaster/toastergui/templates/target.html   | 115 +---
> bitbake/lib/toaster/toastergui/templates/task.html |   2 +-
> .../lib/toaster/toastergui/templates/tasks.html    | 143 -----
> bitbake/lib/toaster/toastergui/tests.py            |  40 +-
> bitbake/lib/toaster/toastergui/urls.py             |  46 +-
> bitbake/lib/toaster/toastergui/views.py            | 650
>+--------------------
> bitbake/lib/toaster/toastergui/widgets.py          |  11 +-
> 18 files changed, 763 insertions(+), 1205 deletions(-)
> create mode 100644 bitbake/lib/toaster/toastergui/buildtables.py
> delete mode 100644 bitbake/lib/toaster/toastergui/templates/bpackage.html
> create mode 100644
>bitbake/lib/toaster/toastergui/templates/buildinfo-toastertable.html
> delete mode 100644
>bitbake/lib/toaster/toastergui/templates/buildtime.html
> delete mode 100644 bitbake/lib/toaster/toastergui/templates/recipes.html
> create mode 100644
>bitbake/lib/toaster/toastergui/templates/snippets/gitrev_popover.html
> delete mode 100644 bitbake/lib/toaster/toastergui/templates/tasks.html
>
>-- 
>2.7.4
>
>-- 
>_______________________________________________
>toaster mailing list
>[email protected]
>https://lists.yoctoproject.org/listinfo/toaster

-- 
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to