I've looked at Elliot's patches, apart from that one little thing it looks good to me.

Thanks,

Michael

On 07/06/16 10:42, Smith, Elliot wrote:
Thanks Ed. I've been through and reviewed your patches from this series, and they look good to me.

Michael has said he will review my patches in this series.

Once they're all reviewed, I'll pull them into toaster-next.

Elliot

On 6 June 2016 at 17:01, Ed Bartosh <[email protected] <mailto:[email protected]>> wrote:

    Hi,

    With this set of fixes I was able to run Toaster and build
    core-image-minimal for 'Local Yocto Project'.

    The following changes since commit
    14d075921ef5c5577a0a0acc394399b10f4fcbe8:

      toaster: Rework displaying package dependencies across Toaster
    (2016-06-06 15:25:44 +0300)

    are available in the git repository at:

      git://git.yoctoproject.org/poky-contrib
    <http://git.yoctoproject.org/poky-contrib> ed/toaster/python3
    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/python3

    Ed Bartosh (6):
      bitbake: toaster: use python3 explicitly
      toaster: replace viewkeys() -> keys()
      toaster: fix migrations
      toaster: decode response content
      toaster: fix incorrect file mode
      toaster: fix test_toaster_tables

    Elliot Smith (3):
      toaster: fix broken reference to urllib
      toaster-tests: fix tests for latest Selenium version
      toaster: open image files in binary mode when sending in response

     bitbake/bin/toaster                                |  4 +-
     bitbake/lib/bb/ui/buildinfohelper.py               |  2 +-
     .../migrations/0004_auto_20160523_1446.py          | 34 +++++++++
     .../orm/migrations/0007_auto_20160523_1446.py      | 89
    ++++++++++++++++++++++
     bitbake/lib/toaster/tests/browser/README           |  7 +-
     .../toaster/tests/browser/test_js_unit_tests.py    |  8 +-
     bitbake/lib/toaster/toastergui/tests.py            | 46 +++++------
     bitbake/lib/toaster/toastergui/views.py            |  2 +-
     bitbake/lib/toaster/toastergui/widgets.py          |  2 +-
     9 files changed, 156 insertions(+), 38 deletions(-)
     create mode 100644
    bitbake/lib/toaster/bldcontrol/migrations/0004_auto_20160523_1446.py
     create mode 100644
    bitbake/lib/toaster/orm/migrations/0007_auto_20160523_1446.py

    --
    Regards,
    Ed

    --
    _______________________________________________
    toaster mailing list
    [email protected] <mailto:[email protected]>
    https://lists.yoctoproject.org/listinfo/toaster




--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre



--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to