On 19/07/2016 14:55, "Smith, Elliot" <[email protected]> wrote:
>On 19 July 2016 at 14:39, Barros Pena, Belen ><[email protected]> wrote: > > > >On 18/07/2016 11:54, "[email protected] on behalf of Elliot >Smith" <[email protected] on behalf of >[email protected]> wrote: > >>All of the columns for the tasks and recipes tables (sub-pages of the >>build-dashboard) are optional. This means you can remove all the columns >>for >>those tables and make them disappear from the page. >> >>Set the non-hideable columns and add some UI tests to check that those >>columns >>are disabled in the edit columns drop-down. >> >>The following changes since commit >>562c6e06be41026f59bee3703ee553b57896872a >>(toaster-next): >> >> toaster-tests: package count/size shouldn't show for non-image builds >>(2016-07-15 11:16:28 -0700) >> >>are available in the git repository at: >> >> git://git.yoctoproject.org/poky-contrib >><http://git.yoctoproject.org/poky-contrib> >>elliot/toaster/9833-remove_columns >> >>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/9 >>8 >>33-remove_columns > >This works, but we have a small problem with the tasks tables: tasks, >time, CPU usage and Disk I/O. They all have the same "core columns" (the >ones you cannot hide), but that's not the right thing to do, since their >purpose is to display different information. The original designs (back in >the day) asked for the following core columns: > > > > >Thanks for looking Belen. > > >The core columns being incorrect on those other tables is a separate >issue, so could you please raise a bug for it? > > >(NB the bug was introduced when the tables were migrated to ToasterTable >recently, but doesn't have any bearing on 9833.) Very true. Here is the bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9977 > > >Note that I set the default columns for the tasks and recipes table, so >if they're wrong, I'll change them (I went by the designs on >yoctoproject.org/toaster <http://yoctoproject.org/toaster>, which may be >out of date). Well, it is in general quite out of date, but not on that specific thing. If you look at the tasks, time, cpu and disk I/O tables in the design prototype, they still show the correct core columns (the same ones I listed below). Cheers Belén > > >Thanks. >Elliot > > > >Tasks table: order, recipe and task >Time table: recipe, task and time >CPU usage: recipe, task, system CPU and user CPU >Disk I/O: recipe, task and disk I/O > >I understand the 4 are implemented using the same base table, but having >the same core columns across the 4 causes 2 issues: > >1. You can have a table called 'Time' where you can show no time >information. That makes little sense, and applies also to cpu and disk I/O >tables > >2. You can never show the 'order' column in the time, cpu and disk I/O >tables, because the 'order' checkbox is disabled in the 'edit columns' >menu > >Hopefully there is something we can do. > >Thanks! > >Belén > > >> >>Related bug: >https://bugzilla.yoctoproject.org/show_bug.cgi?id=9833 ><https://bugzilla.yoctoproject.org/show_bug.cgi?id=9833> >> >>Elliot Smith (3): >> toaster: set non-hideable columns for build tasks table >> toaster: set non-hideable columns for built recipes table >> toaster-tests: add tasks and recipes sub-page tests >> >> .../browser/test_builddashboard_page_recipes.py | 66 >>++++++++++++++++++++++ >> .../browser/test_builddashboard_page_tasks.py | 65 >>+++++++++++++++++++++ >> bitbake/lib/toaster/toastergui/buildtables.py | 7 ++- >> 3 files changed, 137 insertions(+), 1 deletion(-) >> create mode 100644 >>bitbake/lib/toaster/tests/browser/test_builddashboard_page_recipes.py >> create mode 100644 >>bitbake/lib/toaster/tests/browser/test_builddashboard_page_tasks.py >> >>-- >>2.7.4 >> >>-- >>_______________________________________________ >>toaster mailing list >>[email protected] >>https://lists.yoctoproject.org/listinfo/toaster > > > > > > > > >-- >Elliot Smith >Software Engineer >Intel Open Source Technology Centre > > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
