yoavs 2004/12/08 07:45:24
Modified: catalina/src/share/org/apache/catalina/authenticator Tag:
TOMCAT_5_0 DigestAuthenticator.java
webapps/docs Tag: TOMCAT_5_0 changelog.xml
Log:
Bugzilla 32502: memory leak in DigestAuthenticator.
Revision Changes Path
No revision
No revision
1.6.2.1 +1 -26
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java
Index: DigestAuthenticator.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java,v
retrieving revision 1.6
retrieving revision 1.6.2.1
diff -u -r1.6 -r1.6.2.1
--- DigestAuthenticator.java 22 Apr 2004 21:48:32 -0000 1.6
+++ DigestAuthenticator.java 8 Dec 2004 15:45:24 -0000 1.6.2.1
@@ -112,28 +112,6 @@
/**
- * No once hashtable.
- */
- protected Hashtable nOnceTokens = new Hashtable();
-
-
- /**
- * No once expiration (in millisecond). A shorter amount would mean a
- * better security level (since the token is generated more often), but
at
- * the expense of a bigger server overhead.
- */
- protected long nOnceTimeout = TIMEOUT_INFINITE;
-
-
- /**
- * No once expiration after a specified number of uses. A lower number
- * would produce more overhead, since a token would have to be generated
- * more often, but would be more secure.
- */
- protected int nOnceUses = USE_ONCE;
-
-
- /**
* Private key.
*/
protected String key = "Catalina";
@@ -404,9 +382,6 @@
byte[] buffer = md5Helper.digest(nOnceValue.getBytes());
nOnceValue = md5Encoder.encode(buffer);
-
- // Updating the value in the no once hashtable
- nOnceTokens.put(nOnceValue, new Long(currentTime + nOnceTimeout));
return nOnceValue;
}
No revision
No revision
1.70.2.88 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
Index: changelog.xml
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
retrieving revision 1.70.2.87
retrieving revision 1.70.2.88
diff -u -r1.70.2.87 -r1.70.2.88
--- changelog.xml 3 Dec 2004 17:02:25 -0000 1.70.2.87
+++ changelog.xml 8 Dec 2004 15:45:24 -0000 1.70.2.88
@@ -34,6 +34,9 @@
<subsection name="Catalina">
<changelog>
+ <fix>
+ <bug>32502</bug>: Memory leak in DigestAuthenticator. (yoavs)
+ </fix>
</changelog>
</subsection>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
