Shawn,

Sorry for the slow response on this -- I'm still catching up from two
weeks on the road speaking at conferences.

Go ahead and send your patches directly to me, and I'll take a
look, and get them installed as needed, on both jakarta-watchdog (servlet
2.2 / JSP 1.1) and jakarta-watchdog-4.0 (servlet 2.3 / JSP 1.2,
although there are few tests for the new fucntionality yet).

On the text/html question, one thing to note in Servlet 2.3 (doesn't apply
to servlet 2.2) the server is explicitly prohibited from setting a content
type if the application doesn't.

Craig


On Wed, 11 Apr 2001, Shawn McMurdo wrote:

> Thanks Marc!
> That would be great.
> Below are my comments from the message to watchdog-dev.
> Also, one change was because the test unnecessarily assumes
> the default mime type for the server is not "text/html".
> Attached is the patch.
> Let me know if you have any questions.
> Thanks again.
> Shawn
> 
> Original comments:
> 
> Hi,
> I have been working with the watchdog tests using Jigsaw and
> HTTP 1.1
> and Enhydra and have found a few problems in the tests.
> These are mainly related to the tests not being able to handle
> multiple
> headers being sent on a single header line as is done in HTTP
> 1.1.
> There are also some problems with the tests expecting a
> particular
> date format and timezone.
> And finally, some tests use the "Set-Cookie" header with no name
> and only a
> value,
> which is not correct in the current cookie spec. Since these
> tests are not
> designed to
> test cookies or cookie headers it is not necessary to use the
> "Set-Cookie"
> header.
> 
> I have attached a complete patch file that includes all changes.
> Would it be preferable to send individual diffs for each file?
> There are 13 modified files and a total of 330 lines in the
> overall "diff -u"
> patch file.
> I created the diff against the 2001-02-03 source release.
> Let me know if you want a different format or need additional
> information.
> Discussion of the changes is welcomed.
> Thanks.
> Shawn
> 
> 
> Marc Saegesser wrote:
> 
> > Shawn,
> >
> > Could re-post your patches?  I don't have the your original email with the
> > patches.  I'll see if I can find time look at them.
> >
> > Marc Saegesser
> >
> > > -----Original Message-----
> > > From: Shawn McMurdo [mailto:[EMAIL PROTECTED]]
> > > Sent: Wednesday, April 11, 2001 8:11 PM
> > > To: [EMAIL PROTECTED]
> > > Subject: Re: [Fwd: Watchdog sleeping?]
> > >
> > >
> > > Hi Jeff,
> > > Thanks for the info and the pointer!
> > > Shawn
> > >
> > > Jeff Turner wrote:
> > >
> > > > On Wed, Apr 11, 2001 at 01:22:37PM -0400, Shawn McMurdo wrote:
> > > > > No one on watchdog-dev or general seems to know anything about
> > > > > the status of Watchdog.
> > > > > Does anyone here on tomcat-dev know what is up with Watchdog?
> > > >
> > > > I think it's rather dead. Craig is in charge of it now. From
> > > the IRC logs for
> > > > the PMC meeting:
> > > >
> > > > <craigmcc> Question:  is there any widespread continued
> > > interest in tools or
> > > > watchdog?
> > > > <craigmcc> as Jakarta subprojects, I mean?
> > > > <jon> not that i know of
> > > > <Sam> Craig: I'd like to assign these subprojects to you and
> > > let you determine
> > > > what is best for them.
> > > > <craigmcc> sounds good (re tools/watchdog)
> > > >
> > > >   http://jakarta.apache.org/site/pmc/01-03-19-meeting-irclog.html
> > > >
> > > > --Jeff
> > > >
> > > > > Shawn
> > > > >
> > > > > --
> > > > > Shawn McMurdo              mailto:[EMAIL PROTECTED]
> > > > > Lutris Technologies        http://www.lutris.com
> > > > > Enhydra.Org                http://www.enhydra.org
> > >
> > > --
> > > Shawn McMurdo              mailto:[EMAIL PROTECTED]
> > > Lutris Technologies        http://www.lutris.com
> > > Enhydra.Org                http://www.enhydra.org
> > >
> 
> --
> Shawn McMurdo              mailto:[EMAIL PROTECTED]
> Lutris Technologies        http://www.lutris.com
> Enhydra.Org                http://www.enhydra.org
> 
> 

Reply via email to