costin 01/05/27 19:09:55 Modified: src/share/org/apache/tomcat/util/qlog FastDateFormat.java Log: Roll back the previous change - problems if you compile with 1.4 and run with 1.3 Revision Changes Path 1.3 +5 -1 jakarta-tomcat/src/share/org/apache/tomcat/util/qlog/FastDateFormat.java Index: FastDateFormat.java =================================================================== RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/qlog/FastDateFormat.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- FastDateFormat.java 2001/05/26 17:28:55 1.2 +++ FastDateFormat.java 2001/05/28 02:09:55 1.3 @@ -123,8 +123,12 @@ sb.setCharAt(--pos, Character.forDigit(ms % 10, 10)); } } - toAppendTo.append(sb); // StringBuffer will call toString internally, + toAppendTo.append(sb.toString()); + // StringBuffer will call toString internally, // except for 1.4 where append(SB) is defined - one more object saved + // Bad if you compile with 1.4 - it'll no longer work on 1.2, so + // toString will be used ( this can be optimized using the buffers + // directly ) return toAppendTo; }