Re: [TC3.2.3][PATCH] mod_jk / mod_rewrite bug fix

[Pier P. Fumagalli]

Justin Erenkrantz at [EMAIL PROTECTED] wrote:

> On Wed, Aug 15, 2001 at 03:41:30AM +0100, Pier P. Fumagalli wrote:
>> Justin Erenkrantz at [EMAIL PROTECTED] wrote:
>>> 
>>> I wonder how Pier is addressing this in mod_webapp.  I'll have to
>>> look.  -- justin
>> 
>> Easy as 1.2.3... WARP has a concept of URI and QUERY STRING... Very separate
>> things... All I do is
>> 
>>     req->ruri=apr_pstrdup(req->pool,r->uri);
>>     req->args=apr_pstrdup(req->pool,r->args);
>> 
>> The URI goes into the URI, the query string goes into the query string...
>> Apache does it for me, why should I bother? :)
> 
> Which, of course, is the right solution.

DOH! :) Am I lucky or what???? :) :) :)

> But, do you have to (re)escape the uri (or, is that done in Java
> land?)?  Seems like the 2.2 spec says that the getRequestURI()
> function must return an escaped URI.  r->uri is unescaped.  Or, does
> 2.3 say something different?  -- justin

It's done in Java land (well, in theory! :) I should really check, that
might be one hit of performance improvement (like 1 millisecond per
request).

Ok, get over it Pier, performance is after the beta :)

    Pier (love talking to himself -who, me?- at 4 AM :)