Hi Remy, Can you explain a bit what's this ActionCode ? I understant it as a hook mechanism, and I like that - but I'm not sure I like the implementation.
For example, any reason not to use a plain 'int' as action code ? At least that would allow switch() which is slightly faster ( when the number of actions will grow ). Also, how do you plan to 'grow' - you can't just add static fields - what about dynamic hook ? If you allow ActionCodes that are not defined as static fields ( so you can use == ), you'll be forced to use .equals(), that would be pretty bad. There are few other things we need to discuss before implementing - but that's one of the most obvious. ( I'm not saying that Hooks are better, just that we need to discuss a bit the details of coyote ) Costin On 1 Oct 2001 [EMAIL PROTECTED] wrote: > remm 01/09/30 18:09:54 > > Modified: coyote/src/java/org/apache/coyote ActionCode.java > Log: > - Add a commit action code. > > Revision Changes Path > 1.2 +6 -3 >jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/ActionCode.java > > Index: ActionCode.java > =================================================================== > RCS file: >/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/ActionCode.java,v > retrieving revision 1.1 > retrieving revision 1.2 > diff -u -r1.1 -r1.2 > --- ActionCode.java 2001/07/10 02:54:59 1.1 > +++ ActionCode.java 2001/10/01 01:09:54 1.2 > @@ -70,16 +70,19 @@ > // -------------------------------------------------------------- Constants > > > - public static final ActionCode ACTION_CUSTOM = new ActionCode(); > + public static final ActionCode ACTION_ACK = new ActionCode(); > > > public static final ActionCode ACTION_CLOSE = new ActionCode(); > > > - public static final ActionCode ACTION_RESET = new ActionCode(); > + public static final ActionCode ACTION_COMMIT = new ActionCode(); > > > - public static final ActionCode ACTION_ACK = new ActionCode(); > + public static final ActionCode ACTION_CUSTOM = new ActionCode(); > + > + > + public static final ActionCode ACTION_RESET = new ActionCode(); > > > // ----------------------------------------------------------- Constructors > > > >
