And for what it's worth...
Here is a piece of the e-mail I sent to Bip... just in case anyone
is curious what I changed. (I sent the e-mail to him directly since
tomcat-dev was on 14 hour delay at that time and he said he was
going to be out of contact for a while.)
> The patches fix one major issue and include several enhancements.
>
> The main fix is that concurrent access to the SSI module was broken
> before and would most readily manifest itself as broken nesting.
> But the same problem would occur if two clients hit the server at
> the same time. One would see the other's output.
>
> As far as enhancements, I've added support for the "set" directive
> and variable substitution. (i.e.: $someVar and ${someVar} are now
> allowed in the appropriate places.) The initial support for
> conditionals has also been added. I just need to make the
> SsiCommands for "if", "else", etc..
So, with the above changes, SSI should be safe to use from multiple
clients. Locally, I've also finished coding the conditional
directives and some other fixes to SsiInvokerServlet. I'll post
those changes later today just in case someone wants to use or commit
them.
-Paul Speed
Paul Speed wrote:
>
> Ahah!
>
> This is an easy one to fix. I just checked out the latest source and
> it looks like Bip may have forgotten to "cvs remove" SsiMediator.java.
> That's easy to do when you're updating a whole directory. Nuke this
> file and everything should be good.
>
> Let me know if you have any more problems.
> -Paul Speed
>
> [EMAIL PROTECTED] wrote:
> >
> > craigmcc 01/10/26 17:50:05
> >
> > Modified: catalina build.xml
> > Log:
> > Add a kludge to avoid compiling the SSI servlet (and associated utilities)
> > because the build is currently broken, and I haven't seen the commit
> > message yet (due to the mail delay) in order to properly revert it.
> >
> > Once the compile problems are fixed, simply uncomment the <property>
> > setting for compile.ssi, or include a setting like this in
> > build.properties:
> >
> > compile.ssi=true
> >
> > Revision Changes Path
> > 1.81 +8 -0 jakarta-tomcat-4.0/catalina/build.xml
> >
> > Index: build.xml
> > ===================================================================
> > RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/build.xml,v
> > retrieving revision 1.80
> > retrieving revision 1.81
> > diff -u -r1.80 -r1.81
> > --- build.xml 2001/10/26 02:03:28 1.80
> > +++ build.xml 2001/10/27 00:50:05 1.81
> > @@ -233,6 +233,9 @@
> > <equals arg1="${jdk.1.3.present}" arg2="true" />
> > </or>
> > </condition>
> > +<!-- Uncomment this to compile the SSI code
> > + <property name="compile.ssi" value="true"/>
> > +-->
> > <condition property="compile.tyrex">
> > <or>
> > <equals arg1="${full.dist}" arg2="on" />
> > @@ -417,6 +420,7 @@
> > <echo message="compile.jta=${compile.jta}" />
> > <echo message="compile.junit=${compile.junit}" />
> > <echo message="compile.ldap=${compile.ldap}" />
> > + <echo message="compile.ssi=${compile.ssi}" />
> > <echo message="compile.tyrex=${compile.tyrex}" />
> >
> > <echo message="--- Distribution flags ---" />
> > @@ -568,6 +572,10 @@
> > unless="compile.jmx"/>
> > <exclude name="org/apache/catalina/net/SSLServerSocketFactory.java"
> > unless="compile.jsse"/>
> > + <exclude name="org/apache/catalina/servlets/SsiInvokerServlet.java"
> > + unless="compile.ssi"/>
> > + <exclude name="org/apache/catalina/util/ssi/**"
> > + unless="compile.ssi"/>
> > <exclude name="org/apache/catalina/valves/CertificatesValve.java"
> > unless="compile.jsse"/>
> > <exclude name="org/apache/naming/factory/MailSessionFactory.java"
> >
> >
> >
>
> --
> To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
