Jon Stevens <[EMAIL PROTECTED]> writes:

> on 11/27/01 2:34 PM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
>
>> Index: setenv.sh
>> ===================================================================
>> #!/bin/sh
>> # 
>> -----------------------------------------------------------------------------
>> # setenv.sh - File to hold all user customizable environment variables
>> #
>> # $Id: setenv.sh,v 1.1 2001/11/27 22:34:25 patrickl Exp $
>> # 
>> -----------------------------------------------------------------------------
>> 
>> # To permanently set your JAVA_HOME environment variable, uncomment and
>> # customize the following line with the absolute path to your JAVA_HOME
>> # JAVA_HOME=/usr/java
>
> -1
>
> I don't think that this file should exist in CVS if it is a user file.
>
> The problem being that if a user upgrades to a new version of Catalina, then
> they will risk overwriting this file.
>
> Instead, it should be documented that the file needs to be created in order
> to be used.

I agree with Jon.  Files editted by the user should never be in CVS --
clear documentation is key here.  Other than that, I like the change!

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to