> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, April 09, 2002 2:09 PM
> To: Tomcat Developers List
> Subject: RE: cvs commit: jakarta-tomcat build.xml
>
>
> On Tue, 9 Apr 2002, Larry Isaacs wrote:
>
> > The instructions for installing Coyote on Tomcat 3.3.x say to
> > replace connectors_util.jar with j-t-c's tomcat-utils.jar. Since
>
> j-t-c tomcat-utils are a subset of tomcat-utils.jar from container/
>
> Sorry, I didn't read the instructions for Coyote - I'm using coyote
> with the 'old' minimal common loader and it works fine.
>
> I have 2 concerns:
> - we can't have same tomcat-utils.jar name and different content
> in common and container.
> - I want to make sure all code that goes to common is carefully
> reviewed from security standpoint. We had a potential problem
> with jdk11 compat package ( now it is safe, but at some point it
> wasn't ). That's the main reason for keeping only minimal utils.
I'm +1 on this too.
>
>
> > the tomcat-utils.jar that j-t-c builds. So why not just use the
> > "util" jar that j-t-c builds? I would be +1 for renaming the
> > "util" jar that j-t-c builds to connectors_util.jar to avoid
> > name confusion with the tomcat_util.jar.
>
> Or we can rename container/tomcat_util.jar to
> container/container_util.jar, and leave tomcat_util name to j-t-c.
You mean leave "tomcat-util" to j-t-c. Yes, '-' and '_' aren't
sufficient differences in the name. Using container_util.jar sounds
good to me. Are you okay with using the tomcat-utils.jar built
by j-t-c, rather than the current build creation of
connector_utils.jar?
>
> Both are fine - but we still need to review any extra class that
> ends in common ( i.e. re-read the code and look for static
> methods/fields, package-protected methods, doPriviledged blocks, etc )
> I will do that, but it would help if you could duplicate :-)
> ( duplication is good sometimes ).
I'll try to find some time to help with this.
Cheers,
Larry
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
