> On Tue, 9 Apr 2002, Remy Maucherat wrote: > > > > port if it is not the standard one. > > > > > > But if the Host header is correct, it'll allways be the same thing as > > > the getPort on socket - if it's https on standard port, the port will > > > be 443 as the default, etc. > > > > Even if the port in the host header isn't correct, we have to use it. Even > > if the socket isn't 80, we also have to default to that. That's bug 6668. > > You're right. My mistake, if the Host header is present we must use the > default port. > > That open another issue - the port must be what the 'original uri' > specified - but what if you have a proxy that unencrypts SSL and forwards > to the http port ? Probably that's fine since all Host headers I've seen > for https include the port explicitely. > > I'll revert ( or did you do it already ? )
Yes, I modified the patch already. It's a good idea to set the socket port for HTTP/1.0, though (read below). > > Yes, HTTP/1.0 (with old style keepalives; that's new in Coyote HTTP/1.1) and > > HTTP/0.9 are supported. > > When using HTTP/1.0, the host header will be null, so we'll be using that > > code. > > Is there anything wrong ? > > Well, this part I think I'm right. > > If no Host header is specified - we should use the information from > the socket, instead of defaulting to 80. Yes, that's what the fixed patch does. So I did it right, I think :) Remy -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
