manveen 02/04/18 00:39:28
Modified: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve
ValveUtil.java
Log:
fix for adding valve to service.
Revision Changes Path
1.4 +14 -9
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java
Index: ValveUtil.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ValveUtil.java 12 Apr 2002 22:06:30 -0000 1.3
+++ ValveUtil.java 18 Apr 2002 07:39:28 -0000 1.4
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v
1.3 2002/04/12 22:06:30 manveen Exp $
- * $Revision: 1.3 $
- * $Date: 2002/04/12 22:06:30 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v
1.4 2002/04/18 07:39:28 manveen Exp $
+ * $Revision: 1.4 $
+ * $Date: 2002/04/18 07:39:28 $
*
* ====================================================================
*
@@ -94,7 +94,7 @@
* A utility class that contains methods common across valves.
*
* @author Manveen Kaur
- * @version $Revision: 1.3 $ $Date: 2002/04/12 22:06:30 $
+ * @version $Revision: 1.4 $ $Date: 2002/04/18 07:39:28 $
*/
public final class ValveUtil {
@@ -136,8 +136,8 @@
try {
String objectName = DeleteLoggerAction.getObjectName(parent,
- TomcatTreeBuilder.REALM_TYPE);
-
+ TomcatTreeBuilder.VALVE_TYPE);
+
ObjectName pname = new ObjectName(parent);
StringBuffer sb = new StringBuffer(pname.getDomain());
@@ -157,8 +157,11 @@
response.sendError(HttpServletResponse.SC_BAD_REQUEST, message);
return (null);
}
+
+ // Ensure that the requested valve name is unique
- // Ensure that the requested user database name is unique
+ // TBD -- do we need this check?
+ /*
ObjectName oname =
new ObjectName(objectName);
if (mBServer.isRegistered(oname)) {
@@ -170,14 +173,16 @@
response.sendError(HttpServletResponse.SC_BAD_REQUEST, message);
return (new ActionForward(mapping.getInput()));
}
+ */
// Look up our MBeanFactory MBean
ObjectName fname =
new ObjectName(TomcatTreeBuilder.FACTORY_TYPE);
// Create a new StandardValve object
- values = new String[1];
- values[0] = parent;
+ values = new String[1];
+ values[0] = parent;
+
operation = "create" + valveType;
if ("AccessLogValve".equalsIgnoreCase(valveType))
operation = "createAccessLoggerValve";
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
