costin 2003/01/16 21:55:41
Modified: catalina/src/share/org/apache/catalina/util CookieTools.java
Log:
I am not very sure this is the right fix - but from the spec it seems
to be ok.
It seems some browsers ( some versions of IE on Mac ) have trouble parsing
the cookie in HTTPS mode. That happens because we send
"...path=/foo;Secure"
The spec on netscape site has all examples with a space after ;, and
aparently IE uses the space as delimiter.
I'll investigate further, this is very strange...
Revision Changes Path
1.2 +11 -11
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/CookieTools.java
Index: CookieTools.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/CookieTools.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- CookieTools.java 18 Jul 2002 16:47:45 -0000 1.1
+++ CookieTools.java 17 Jan 2003 05:55:41 -0000 1.2
@@ -122,11 +122,11 @@
// add version 1 specific information
if (version == 1) {
// Version=1 ... required
- buf.append (";Version=1");
+ buf.append ("; Version=1");
// Comment=comment
if (cookie.getComment() != null) {
- buf.append (";Comment=");
+ buf.append ("; Comment=");
maybeQuote (version, buf, cookie.getComment());
}
}
@@ -134,14 +134,14 @@
// add domain information, if present
if (cookie.getDomain() != null) {
- buf.append(";Domain=");
+ buf.append("; Domain=");
maybeQuote (version, buf, cookie.getDomain());
}
// Max-Age=secs/Discard ... or use old "Expires" format
if (cookie.getMaxAge() >= 0) {
if (version == 0) {
- buf.append (";Expires=");
+ buf.append ("; Expires=");
if (cookie.getMaxAge() == 0)
DateTool.oldCookieFormat.format(new Date(10000), buf,
new FieldPosition(0));
@@ -151,21 +151,21 @@
cookie.getMaxAge() *1000L), buf,
new FieldPosition(0));
} else {
- buf.append (";Max-Age=");
+ buf.append ("; Max-Age=");
buf.append (cookie.getMaxAge());
}
} else if (version == 1)
- buf.append (";Discard");
+ buf.append ("; Discard");
// Path=path
if (cookie.getPath() != null) {
- buf.append (";Path=");
+ buf.append ("; Path=");
maybeQuote (version, buf, cookie.getPath());
}
// Secure
if (cookie.getSecure()) {
- buf.append (";Secure");
+ buf.append ("; Secure");
}
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
