----- Original Message ----- 
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, January 06, 2004 9:32 PM
Subject: cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server
JkCoyoteHandler.java


> billbarker    2004/01/06 21:32:44
>
>   Modified:    jk/java/org/apache/jk/server JkCoyoteHandler.java
>   Log:
>   Adding the required PAs to allow the Coyote-Jk connector to play in the
sandbox.

I'm not really happy with how this turned out.  The C2BC issue could
actually get solved by moving the check for 'null', but it just didn't seem
worth it (since it is a re-used component, the PA is invoked rarely).
However, invoking a PA for the status line bothers me.  My suggestion is to
change o.a.t.u.http.HttpMessages to make 'getMessage' an instance (instead
of the current static) method, and make everyone that wants to use it create
an instance (at a point where they know the call-stack is clean).  Excess
memory usage should be pretty small, and you avoid a big hit with the PA.

As always, I'm volunteering to do the code-monkey (&copy; Pier) part of the
project for TC 3.3.x-5.x.

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to