DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26832>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26832 Incorrect logic checking return value of jk_requtil_escapeUrl in jk_isapi_plugin.c Summary: Incorrect logic checking return value of jk_requtil_escapeUrl in jk_isapi_plugin.c Product: Tomcat 5 Version: 5.0.18 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Native:JK AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In the file jk_requtil.c jk_requtil_escapeUrl() returns JK_OK (which evaluates to 0) to indicate success. In the current jk_isapi_plugin.c the call expects 0 to mean failure as follows: if (!jk_requtil_escapeUrl(uri,snuri,INTERNET_MAX_URL_LENGTH)) { env->l->jkLog(env, env->l, JK_LOG_ERROR, "HttpFilterProc [%s] re-encoding request exceeds maximum buffer size.\n", uri); write_error_response(pfc,"400 Bad Request", HTML_ERROR_400); workerEnv->globalEnv->releaseEnv( workerEnv->globalEnv, env ); return SF_STATUS_REQ_FINISHED; } The if statement should be changed to: if (jk_requtil_escapeUrl(uri,snuri,INTERNET_MAX_URL_LENGTH) != JK_OK) { --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
