Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:
luehe       2004/03/10 20:18:31

  Modified:    catalina/src/share/org/apache/catalina/session
                        StandardSession.java
  Log:
  Fixed regression re: Bugtraq 4839736
  ("HttpSession.setMaxInactiveInterval() doesn't behave as expected"),
  which had been originally fixed in revision 1.20
-1. I don't agree with this change: the session is (apparently) supposed 
to be valid while it is being accessed, regardless of MaxInactiveInterval.

  -        if (accessCount > 0) {
  -            return true;
  -        }
  -
           if (maxInactiveInterval >= 0) { 
               long timeNow = System.currentTimeMillis();
               int timeIdle = (int) ((timeNow - thisAccessedTime) / 1000L);
               if (timeIdle >= maxInactiveInterval) {
                   expire(true);
               }
  +        }
  +
  +        if (accessCount > 0) {
  +            return true;
           }
Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]