----- Original Message ----- 
From: "Amy Roh" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Monday, April 26, 2004 6:07 PM
Subject: wrong timeIdel value in StandardSession

> The following patch causes regression where sessions don't expire when it
> should.  I have a test app that does refresh every 70 sec.  When I set
> timeout to 2 minute - the session *never* expires.

I see the change to be not so much a regression as a bug-fix :).  Your app
is accessing the session every 70 sec, so the session is never idle for the
required 2 min to allow it to expire.

> cvs diff -r 1.26 -r 1.27 StandardSession.java
> 587c587
> <             int timeIdle = (int) ((timeNow - lastAccessedTime) / 1000L);
> ---
> >             int timeIdle = (int) ((timeNow - thisAccessedTime) / 1000L);
> I propose to revert the patch.

I'm -1 on reverting unless you can explain why you think that the previous
behavior is correct wrt the spec.  And, no, the fact that this bug has been
in every version of Tomcat back to at least 3.2.x isn't good enough ;-).

> Thanks,
> Amy
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to