DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=26400>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=26400 JspC.java produces invalid package names [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|JspC.java can produce |JspC.java produces invalid |invalid package names |package names ------- Additional Comments From [EMAIL PROTECTED] 2004-05-30 17:09 ------- I updated the patch for Tomcat 4.1.30. Please consider including in CVS. The patch is based on JspC.java 1.12.2.8 from the branch tomcat_4_branch. For tomcat 5 this case is already correctly handled (using the same logic), but not in TC 4. *** 985,998 **** --- 985,1005 ---- * @param jspUri the context-relative path for the JSP file, starting * with a slash */ + private String toPackageName(String jspUri) { StringBuffer modifiedPackageName = new StringBuffer(); int iSep = jspUri.lastIndexOf('/'); // Start after the first slash int nameStart = 1; + boolean isFirstIdentifierChar = true; for (int i = 1; i < iSep; i++) { char ch = jspUri.charAt(i); if (Character.isJavaIdentifierPart(ch)) { + if ( isFirstIdentifierChar && + ( !Character.isJavaIdentifierStart(ch)) ) { + modifiedPackageName.append('_'); + isFirstIdentifierChar = false; + } modifiedPackageName.append(ch); } else if (ch == '/') { *************** *** 1001,1006 **** --- 1008,1014 ---- } nameStart = i+1; modifiedPackageName.append('.'); + isFirstIdentifierChar = true; } else { modifiedPackageName.append(mangleChar(ch)); } --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
