luehe 2004/10/14 17:00:35
Modified: catalina/src/share/org/apache/catalina/core
ApplicationHttpResponse.java
Log:
Expose any errors on an included resource.
For example, a JSP with this include action:
<jsp:include page="nonexistent">
or
<jsp:include page="nonexistent.jsp">
where nonexistent[.jsp] does not exist, currently returns silently, hiding the
fact that the resource to be included does not exist.
This patch returns a 404 with the name of the nonexistent resource.
Yes, SRV.8.3 ("The Include Method") mentions that
"it [the target servlet] cannot set headers or call any method that
affects the headers of the response. Any attempt to do so must be
ignored."
but i don't think it is referring to the error case.
Let me know if you see any problems.
Revision Changes Path
1.6 +1 -3
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpResponse.java
Index: ApplicationHttpResponse.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpResponse.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- ApplicationHttpResponse.java 27 Feb 2004 14:58:42 -0000 1.5
+++ ApplicationHttpResponse.java 15 Oct 2004 00:00:35 -0000 1.6
@@ -237,7 +237,6 @@
*/
public void sendError(int sc) throws IOException {
- if (!included)
((HttpServletResponse) getResponse()).sendError(sc);
}
@@ -253,7 +252,6 @@
*/
public void sendError(int sc, String msg) throws IOException {
- if (!included)
((HttpServletResponse) getResponse()).sendError(sc, msg);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
