Hi, Big duh on my part. I just realized the bug spoke Only about the manager docs page. The patch is fine, my mistake, good job fixing it, and thank you ;)
Yoav -----Original Message----- From: Yoav Shapira [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 11, 2005 5:04 PM To: 'Tomcat Developers List' Subject: RE: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of "/" Hi, The docs agree with the behavior only for the manager, that's the problem. Previously the docs agreed with the configuration instructions, e.g. editing server.xml, and disagreed with the manager. So we should clarify in the docs that what the manager reports as "/" is actually "" when you create context.xml files. We've gotten easily 1000 times more questions from people putting "/" in configuration files (which is wrong) than we have people complaining about "/" in the manager. If we have to pick one, the former (the way the docs previously were) is much better. But we don't have to pick just one thankfully, we can have docs that cover both the manager display and the configuration. This issue comes up often enough on the list that this is worthwhile, otherwise I wouldn't have said anything... Yoav -----Original Message----- From: Mark Thomas [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 11, 2005 4:59 PM To: Tomcat Developers List Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length string for root context path instead of "/" The manager would be wrong if: a) we had a consistent way of handling the ROOT context b) the agreed consistent way to reference ROOT was "" I am not aware of a) and from a user perspective "/" seems to make more sense for b) At least at present the docs agree with the actual behaviour. Mark Yoav Shapira wrote: > Hi, > IT might be the manager that's wrong. When editing server.xml or > context.xml files for those Tomcat versions, users should use path="" and > not path="/". The latter leads to significant failures. > > Yoav > > -----Original Message----- > From: Mark Thomas [mailto:[EMAIL PROTECTED] > Sent: Tuesday, January 11, 2005 4:30 PM > To: Tomcat Developers List > Subject: Re: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length > string for root context path instead of "/" > > I did a quick test (on TC4 and TC5) before changing the docs. > > http://localhost:8080/manager/reload?path=/ > returns > OK - Reloaded application at context path / > > http://localhost:8080/manager/reload?path= > returns > FAIL - Invalid context path was specified > > Mark > > Yoav Shapira wrote: > >>Hi, >>I thought the docs were right, path="" for the ROOT, not path="/". And >>therefore I thought this was an invalid bug report. Was I wrong? >> >>Yoav >> >>-----Original Message----- >>From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >>Sent: Tuesday, January 11, 2005 4:11 PM >>To: tomcat-dev@jakarta.apache.org >>Subject: DO NOT REPLY [Bug 28867] - Documentation mentions zero-length >>string for root context path instead of "/" >> >>DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG. >>RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT >><http://issues.apache.org/bugzilla/show_bug.cgi?id=28867>. >>ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND. >>INSERTED IN THE BUG DATABASE. >> >>http://issues.apache.org/bugzilla/show_bug.cgi?id=28867 >> >> >>[EMAIL PROTECTED] changed: >> >> What |Removed |Added >> > > ---------------------------------------------------------------------------- > >> Status|NEW |RESOLVED >> Resolution| |FIXED >> >> >> >> >>------- Additional Comments From [EMAIL PROTECTED] 2005-01-11 22:11 > > ------- > >>Fixed in CVS for 4.1.x and 5.5.x >> >>Thansk for the report and the patch (I actually committed a variation). >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
