Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: > >>luehe 2005/02/23 11:27:56 >> >> Modified: catalina/src/share/org/apache/catalina/authenticator >> FormAuthenticator.java NonLoginAuthenticator.java >> SSLAuthenticator.java SingleSignOn.java >> catalina/src/share/org/apache/catalina/realm >> DataSourceRealm.java JDBCRealm.java JNDIRealm.java >> RealmBase.java UserDatabaseRealm.java >> catalina/src/share/org/apache/catalina/valves ValveBase.java >> Log: >> No change in functionality. >> >> Added new "containerLog" instance var to RealmBase and ValveBase, which is >> initialized as "container.getLogger()" inside setContainer(). >> >> This will make it easier to do something like >> >> containerLog = LogFactory.getLog(container.logName()+".RealmBase"); >> >> in the future, as suggested by Bill Barker. > > > Actually, this is probably a bad idea (or at least the implementation is > bad): the logger must be retrieved only when the context class loader of > the application is set.
This is where I'm not following: ;-) I don't see any dependency on the context's context class loader when calling ContainerBase.getLogger(), which is implemented like this: logger = LogFactory.getLog(logName()); A context's context class loader is required only for loading webapp resources. Jan > This means no retrieving the logger in > ValveBase.setContainer, since this is first called in StandardContext(). --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
