DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=4138>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=4138 ------- Additional Comments From [EMAIL PROTECTED] 2005-03-26 20:46 ------- (In reply to comment #9) > Thanks Mark, but I noticed that it's not in a finally block in case > context.invoke() throws an exception. As per Remy's commit in the commit above, an exception here is a critical error. I view any such exception as a bug. > Plus, it probably doesn't address the issue I mentioned earlier where it may > make more sense to move this ContextClassLoader logic to > StandardWrapperValve. > Thoughts? Serveral: - I don't see any code paths that lead to the service() method being called without switching the ClassLoader. - Provide a test case that demonstrates this is a problem and I'll try and fix it. Otherwise, "If it ain't broke don't fix it" applies. Fixing theoretical bugs is not worth the very real risk of introducing regressions. Finally, if you do have a test case that demonstrates a problem and there is a chance that it may have security implications please note that security issues should be directed to [EMAIL PROTECTED] rather than discussed publically in bugzilla. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
