markt       2005/03/27 12:18:01

  Modified:    catalina/src/share/org/apache/catalina/valves
                        AccessLogValve.java CertificatesValve.java
                        ExtendedAccessLogValve.java JDBCAccessLogValve.java
                        RequestDumperValve.java RequestFilterValve.java
  Log:
  Clean up Eclipse warnings for o.a.c.valves
   - remove unused imports
   - static access warnings
  
  Revision  Changes    Path
  1.19      +2 -3      
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
  
  Index: AccessLogValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- AccessLogValve.java       26 Aug 2004 21:43:51 -0000      1.18
  +++ AccessLogValve.java       27 Mar 2005 20:18:01 -0000      1.19
  @@ -36,7 +36,6 @@
   import javax.servlet.http.HttpSession;
   import org.apache.catalina.HttpResponse;
   import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
   import org.apache.catalina.LifecycleException;
   import org.apache.catalina.LifecycleListener;
   import org.apache.catalina.Request;
  @@ -339,7 +338,7 @@
        */
       public String getInfo() {
   
  -        return (this.info);
  +        return (info);
   
       }
   
  
  
  
  1.12      +1 -3      
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/CertificatesValve.java
  
  Index: CertificatesValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/CertificatesValve.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- CertificatesValve.java    26 Aug 2004 21:43:51 -0000      1.11
  +++ CertificatesValve.java    27 Mar 2005 20:18:01 -0000      1.12
  @@ -29,13 +29,11 @@
   import org.apache.catalina.Context;
   import org.apache.catalina.Globals;
   import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
   import org.apache.catalina.LifecycleException;
   import org.apache.catalina.LifecycleListener;
   import org.apache.catalina.Logger;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  -import org.apache.catalina.Valve;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.connector.RequestWrapper;
   import org.apache.catalina.deploy.LoginConfig;
  
  
  
  1.5       +2 -5      
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java
  
  Index: ExtendedAccessLogValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- ExtendedAccessLogValve.java       26 Aug 2004 21:43:51 -0000      1.4
  +++ ExtendedAccessLogValve.java       27 Mar 2005 20:18:01 -0000      1.5
  @@ -32,14 +32,11 @@
   import java.util.TimeZone;
   import javax.servlet.ServletException;
   import javax.servlet.ServletRequest;
  -import javax.servlet.ServletResponse;
   import javax.servlet.http.Cookie;
   import javax.servlet.http.HttpServletRequest;
  -import javax.servlet.http.HttpServletResponse;
   import javax.servlet.http.HttpSession;
   import org.apache.catalina.HttpResponse;
   import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
   import org.apache.catalina.LifecycleException;
   import org.apache.catalina.LifecycleListener;
   import org.apache.catalina.Request;
  @@ -349,7 +346,7 @@
        */
       public String getInfo() {
   
  -        return (this.info);
  +        return (info);
   
       }
   
  
  
  
  1.4       +0 -2      
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/JDBCAccessLogValve.java
  
  Index: JDBCAccessLogValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/JDBCAccessLogValve.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- JDBCAccessLogValve.java   26 Aug 2004 21:43:51 -0000      1.3
  +++ JDBCAccessLogValve.java   27 Mar 2005 20:18:01 -0000      1.4
  @@ -27,7 +27,6 @@
   import org.apache.catalina.HttpResponse;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.Lifecycle;
  -import org.apache.catalina.LifecycleEvent;
   import org.apache.catalina.LifecycleException;
   import org.apache.catalina.LifecycleListener;
   import org.apache.catalina.util.LifecycleSupport;
  @@ -35,7 +34,6 @@
   import org.apache.catalina.valves.ValveBase;
   import org.apache.catalina.valves.Constants;
   import java.util.Properties;
  -import java.util.Date;
   import java.sql.Timestamp;
   import java.sql.SQLException;
   import java.sql.DriverManager;
  
  
  
  1.7       +1 -8      
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/RequestDumperValve.java
  
  Index: RequestDumperValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/RequestDumperValve.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- RequestDumperValve.java   26 Aug 2004 21:43:51 -0000      1.6
  +++ RequestDumperValve.java   27 Mar 2005 20:18:01 -0000      1.7
  @@ -19,24 +19,17 @@
   
   
   import java.io.IOException;
  -import java.util.ArrayList;
   import java.util.Enumeration;
  -import java.util.Iterator;
   import javax.servlet.ServletException;
  -import javax.servlet.ServletRequest;
  -import javax.servlet.ServletResponse;
   import javax.servlet.http.Cookie;
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
  -import org.apache.catalina.Container;
   import org.apache.catalina.HttpRequest;
   import org.apache.catalina.HttpResponse;
   import org.apache.catalina.Logger;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  -import org.apache.catalina.Valve;
   import org.apache.catalina.ValveContext;
  -import org.apache.catalina.connector.HttpResponseWrapper;
   import org.apache.catalina.util.StringManager;
   
   
  
  
  
  1.7       +1 -4      
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/RequestFilterValve.java
  
  Index: RequestFilterValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/RequestFilterValve.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- RequestFilterValve.java   26 Aug 2004 21:43:51 -0000      1.6
  +++ RequestFilterValve.java   27 Mar 2005 20:18:01 -0000      1.7
  @@ -21,15 +21,12 @@
   import java.io.IOException;
   import java.util.ArrayList;
   import javax.servlet.ServletException;
  -import javax.servlet.ServletRequest;
   import javax.servlet.ServletResponse;
   import javax.servlet.http.HttpServletResponse;
   import org.apache.regexp.RE;
   import org.apache.regexp.RESyntaxException;
  -import org.apache.catalina.Container;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  -import org.apache.catalina.Valve;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.util.StringManager;
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to