DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=33711>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33711 ------- Additional Comments From [EMAIL PROTECTED] 2005-03-29 14:35 ------- Now that 5.5.9 is released, I can look into more complex/risky issues. I see you have done a lot of research, which identifies the problem very clearly. However, I don't really like the proposed solution. How about simply setting the manager field to null since this is the cause of the problem ? Calling recycle on all sessions in StandardManager.stop could do this easily. Index: StandardManager.java =================================================================== RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardManager.java,v retrieving revision 1.28 diff -u -r1.28 StandardManager.java --- StandardManager.java 7 Feb 2005 21:56:32 -0000 1.28 +++ StandardManager.java 29 Mar 2005 12:32:32 -0000 @@ -670,12 +670,16 @@ Session sessions[] = findSessions(); for (int i = 0; i < sessions.length; i++) { StandardSession session = (StandardSession) sessions[i]; - if (!session.isValid()) - continue; try { - session.expire(); + if (session.isValid()) { + session.expire(); + } } catch (Throwable t) { ; + } finally { + // Measure against memory leaking if references to the session + // object are kept in a shared field somewhere + session.recycle(); } } -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
