Howdy,

>I'm very interested to hear what Tomcat gurus/commiters think of this

I for one think it's unneeded.  Like others, I haven't run into the
problems Senor Kruse did, have Digester working fine in multiple webapps
without modifying tomcat's source or installation.

Nonetheless, it's good to see someone actually put his money where his
mouth is, report a problem they're having, try to fix it, come up with a
working solution (even if breaks something else), and report their
findings.  I wish more people did that.

>Does this break something else?

>> 1) in Catalina.java:
>>
>>     /**
>>      * Create and configure the Digester we will be using for
startup.
>>      */
>>     protected Digester createStartDigester() {
>>
>>         // Initialize the digester
>>         Digester digester = new Digester();
>> +       digester.setClassLoader(this.getClass().getClassLoader());

I think this should be OK.

>> 2) in ContextConfig.java:
>>
>>     /**
>>      * Create (if necessary) and return a Digester configured
>> to process the
>>      * web application deployment descriptor (web.xml).
>>      */
>>     private static Digester createWebDigester() {
>>
>>         URL url = null;
>>         Digester webDigester = new Digester();
>> +
>> + webDigester.setClassLoader(ContextConfig.class.getClassLoader());

This I'm suspicious of.  The ContextConfig classloader might be
different than the webapp classloader.  The webapp classloader should
process web.xml.

Yoav Shapira



This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to