Howdy,

>I have been taking a look at the source for 4.1.18 - and have noticed a
>few problems with three classes in the org.apache.catalina.mbeans
>package...

Have you actually run into runtime problems?  This case shouldn't be
that hard to test: come up with a resource string that would generate
the decoding exception (in UTF-8) and see what happens ;)

>Within all three, there is a removeResource, and removeResourceLink
>method which contains this call - URLDecoder.decode(resourceName) which
>generates a java.lang.Exception - which is not handled.

I don't know what JDK you're looking at, but my JavaDocs for 1.4.1 don't
specify an exception out of that method.  It is deprecated, though, and
the replacement (decode(String s, String enc)) does thrown an
UnsupportedEncodingException.

>When compiling the source, I would assume this would need to be fixed
>first, unless there is a magic trick within ANT I am not aware of.
> Don't the distributed binaries come directly from the source?

I don't get any problems compiling 4.1.18.  I'm using JDK 1.4.1_01 on
Solaris 8.  I wouldn't expect any problems because that method doesn't
throw an exception ;)

It'd be nice to patch to the non-deprecated version, but if I remember
correctly the decode() version which takes an encoding parameter is
fairly new and not available on all the JDKs tomcat supports...
Definitely a future to-do though.

Yoav Shapira
Millennium ChemInformatics

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to