I've been spending some time thinking about code review flows that we might implement on the site: how they are advertised, how one declares code/areas of interest, how approvals might be handled. But what always stops me short is that webrev upload is a bit of a pain.
Dan worked around this by using scp(1) to do a recursive copy of the webrev/ directory to cr.grommit.com (the code review swamp he and stevel got running), but delete is an asynchronous request, since there is no recursive delete in (the Solaris) sftp(1) implementation. One way to make upload much easier is for webrev to output a single JavaScript/HTML file that contains all of the various diffs views inside itself. Since we need to support both Subversion and Mercurial, webrev needs a bit of a once over in any case. I've attached the version that the opensolaris I-team has been hacking together: it handles Subversion. The original is available in your ON source drops as usr/src/tools/scripts/webrev.sh or at http://cvs.opensolaris.org/source/xref/on/usr/src/tools/scripts/webrev.sh Thoughts? (If you decide on a "scorched earth" rewrite, please attempt to confine yourself to a language platform shipped with one of the OpenSolaris consolidations...) - Stephen -- Stephen Hahn, PhD Solaris Kernel Development, Sun Microsystems [EMAIL PROTECTED] http://blogs.sun.com/sch/ _______________________________________________ tools-discuss mailing list [email protected]
