On Fri, Apr 28, 2006 at 05:30:24AM -0700, Dermot McCluskey wrote:
> Below are three examples of commit email notifications from CVS
> and SVN, provided in order to gather feedback on what users would
> like to see in these mails from the OpenSolaris SCMs.
>
> The intention is to use the same hook script for all SCM systems
> (SVN and Mercurial) and to have the email format be the same, or
> as similar as possible, for all consolidations.
>
> My personal preferences are:
> - Subject contains "<SCM identifer> <Repository>/<Module> <Author>"
> eg: "SVN commit: jds/spec-files dermot". Possibly add
^^^ ^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^
| | | |
| | | +- author should be in the From: line
| | +-- What would this be for a typical ON commit?
| +--- Must-have.
+--- not very useful or interesting.
> - Body also contains lists of files modified, added and deleted.
> I'd prefer separate lists of each category with a header
> ("Files added:") rather than a list of all changed files with a
> flag indicating what action occurred ("U Makefile"). Files
> could also be grouped by directory
> ("patches/ patch01, patch02, patch03").
Please don't group files by directory; I grab full paths from commit messages
all of the time.
I'd rather have the full list of files, in ascii-betical order, with
an indication of what happened to the file. Just because one file was created
and another file was modified doesn't mean they aren't related.
diffstat output looks interesting, but how do renames fit into it?
> - Commit mails should *not* contain diffs of modified files -
> too much detail.
Agreed.
- jonathan
--
Jonathan Adams, Solaris Kernel Development
_______________________________________________
tools-discuss mailing list
[email protected]
