I'm not naming names because I want to focus on the behavior, not the
person..
Recently someone posted a code review consisting entirely of:
> LGTM.
And shortly thereafter someone else posted:
> ttu ==> two thumbs up.
Using abbreviations like this in response to a code review request
suggests to me that the reviewer was too rushed to do a thorough review.
I tend to discount reviews that are this cursory. If you don't have the
time to type out some variation of: "I reviewed it; fix looks fine, feel
free to RTI listing me as a code reviewer", did you actually have time
to understand the indirect implications of a proposed change?
- Bill
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
