Re: [tools-discuss] wx - in line comments

[Stacey Marshall]

Danek Duvall wrote:

It seems like a worthwhile, if likely short-lived, RFE, but your patch
seems not to be against the current version of wx, and the lack of any
context makes it hard to figure out how it *would* apply.

Context diffs didn't display very well in the forum preview, or I would have included them.

Short lived?  Is wx going away?  Does Mecurial offer some other alternative.

I'm guessing that the argument to wx_show_comment is whether or not the

comment comments should be shown, right?

Yes.

Is that really necessary, or is
the function used for both in cases where you'd want to keep the comments

and in cases where they need to disappear?

Yes, the same function is used to create the putback comments and delget comments where the extra comments are currently not welcome.

If so, I'd choose a different
method -- some sort of flag in the typical "-X" form.

:-)  --no_comments

Danek

Cheers,  Stace

--


http://blogs.sun.com/ace

Stacey Marshall. Solaris Revenue Product Engineering, EMEA -----------------------------------------------------------------------

smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org