>>>>> "meem" == Peter Memishian <[EMAIL PROTECTED]> writes:
meem> * General: THIRDPARTYLICENSE files should be generated as part meem> of `all' rather than `install', since the custom is for `all' to meem> build all of the derived objects, and `install' to install meem> whatever ones need to be packaged. Will fix. meem> * General: Prefer $@ to repeating the target Will fix. meem> usr/src/cmd/cmd-inet/usr.sbin/Makefile: meem> * 275: Remove blank line. Will fix if I haven't already. meem> usr/src/cmd/perl/Makefile: meem> * 57: Would slightly prefer to just add this to line 56. Okay; will do. meem> * 73: I presume bad things happen if one skips the copy and meem> just does: meem> $(PERL) $(PODDIR)/pod2text.PL Yes. Unfortunately, I don't remember what. Let me know if you think the comments should say why the copy is needed. meem> * 73, 77: CP and RM macros already include `-f'. Will fix. meem> usr/src/uts/intel/genunix/Makefile: meem> * I presume this change will be removed before putback. Yup. Already done (see 6527717). Thanks for the review! mike _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
