Hi, Richard Lowe pÃÅ¡e v Ät 28. 08. 2008 v 15:21 -0400: > Milan Jurik <[EMAIL PROTECTED]> writes: > > > Hi, > > > > I (or hg nits) have problem with this code: > > > > 409 (void) fprintf(stderr, gettext( > > 410 "usage: %s [-acm] [-r ref_file] file...\n" > > 411 " %s [-acm] [MMDDhhmm[yy]] file...\n" > > 412 " %s [-acm] [-t [[CC]YY]MMDDhhmm[.SS]] > > file...\n"), > > 413 myname, myname, myname); > > > > C style check: > > usr/src/cmd/touch/touch.c: 413: continuation line improperly indented > > > > I think such code was OK for wx, as the result of one point of view on > > chapter 13. in C style doc. Where am I doing the mistake? How should it > > look like? I tried to move lines 410-412, I tried several formats of line > > 413, no success. > > The code wouldn't have been Ok with wx, they both use cstyle -cPp >
Really? E.g. http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libsldap/common/ns_reads.c#549 passed. And I have older teamware workspace, without complaining. I didn't touch those lines even. > cstyle is unfortunately inspecific about what it wants with nested > continuation lines. > > (here, you're continuing from the gettext() not the fprintf()...) > And how should it look like? C style speaks about lines, not fuctions. And line 413 is continuation of fprintf(). Best regards, Milan
_______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
