Danek Duvall wrote: > I'm a wuss and a complainer. I may have gotten it horribly wrong, but I > made hg-active take a -r argument, as well as spit out copy support. I've > a webrev up at > > http://cr.opensolaris.org/~dduvall/onnv-webrev/ > > Rich, I'm sure you'll cringe at my changes in Workspace.py, but if you'd > take a look, I'd greatly appreciate it. Anyone else is, of course, welcome > to look as well, but once I get the hg-active stuff working, there are bits > I'll rip out from webrev.sh.
WorkSpace.py: - 616: findoutgoing() will also set the self.outgoingcache, but you're skipping that when -r is specified. Is that OK? -- Related question: Is it an error to specify both parent and revs? - 622-627: Is this pertinent when using revs? - 644-648: Seems like these should be rolled up into the previous conditional hg-active.py: - In WorkSpace.py, you're looking for "if revs," but on line 83 here, you're potentially passing an empty list instead of None. Won't that mean that you take the "revs" logic over the "parent" logic in WorkSpace.active(), even when you don't want to? I ran out of steam reviewing webrev.sh, but if it's still fluid, that should be OK, right? --Mark _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
