Jan Friedel wrote:
Hi,
On Wed, May 06, 2009 at 01:54:05PM +0200, Vladimir Kotal wrote:
Hi all,
I'd appreciate if someone could do a code review of 3 really small fixes
in webrev.sh and cmd.py. This is a fallout from other bug fixes/changes.
webrev is here:
http://cr.opensolaris.org/~vkotal/webrev-regressions.onnv/
The proposed changes looks good. Though, it might be worth to
note the special \' case, and why no backslash, in the comments
above the url_encode function ($SRC//tools/scripts/webrev.sh).
Comment added.
Another nit, how 6820408 and 6835735 are related to
$SRC/tools/onbld/hgext/cdm.py and how 6837938 is related to
$SRC/tools/scripts/webrev.sh? They ought to be probably
6835735 and 6837938 are somewhat related, with 6820421 being the
connecting factor. In terms of the changes, they are not related at all.
separated in the webrev (generate the active files list - the
same as in wx environment and give it to webrev via -w option).
I could have used MQ's but thought it overkill for such simple set of
changes.
webrev refreshed.
v.
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
