On Wed, 27 May 2009 22:33:33 -0600 "Mark J. Nelson" <mark.j.nel...@sun.com> wrote:
> Resending to fix braindead mail alias typo... > > Mark J. Nelson wrote: > > This is for > > > >> 6833294 hg nits should accept shortened CDDL block > >> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6833294 > > > > Design notes: I extended the generic comment block checker to take one > > or more valid text blocks. The mapfile comment checker only uses one > > block, and the cddl checker now uses two. When passing multiple, valid > > text blocks, the canonical form should be listed first. > > > > The mapfile checker did not previously warrant its own test, because the > > block checking logic that had been refactored from the original cddl > > checker was thoroughly exercised by the cddl check tests. That's no > > longer true, so I wrote a separate mapfile test script. > > > > The webrevs, one each for code and tests: > > > >> http://cr.opensolaris.org/~mjnelson/webrev.shortcddl/ > >> http://cr.opensolaris.org/~mjnelson/webrev.shortcddl_tests/ > > > > ON folks: I plan to make Cadmium accept either form of the CDDL, and not > > make this configurable. If you disagree, speak up now (or even better, > > speak up a day or two ago when I sent such a question to you internally...) Changes look good to me. /me reminds self to speak up one or two days ago... James -- Senior Kernel Software Engineer, Solaris Sun Microsystems http://blogs.sun.com/jmcp http://www.jmcp.homeunix.com/blog Kernel Conference Australia - http://au.sun.com/sunnews/events/2009/kernel _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
