On Thu, Aug 27, 2009 at 04:50:40PM -0700, Dan Price wrote: > On Thu 27 Aug 2009 at 03:15PM, Mark J. Nelson wrote: > > http://cr.opensolaris.org/~mjnelson/webrev.6876674/ > > > > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6876674 > > http://monaco.sfbay/detail.jsf?cr=6876674 > > > > The bug has not yet propagated to bugs.opensolaris.org, but it's > > pretty much as the synopsis says. > > > > I mostly kept other changes to a minimum, but couldn't resist a little > > bit of cleanup to the Makefile that I copied. > > What a strange corner of the source this is.
Are you sure you're not English? You seem to have their knack for wry understatement... > This looks fine. > > That said, I was mystified about the purpose of SUNW_OST_LINFO > though. The old makefile doesn't 'splain it either. Or what the > significane of MSGDIRFILES_REMOTE vs. LOCAL? I just thought if you had > figured these out it would be good to document them. Good suggestion. The gist is that the _REMOTE files need a rule to copy them into place, and the _LOCAL files don't. I'll add comments to that effect. The alternative is going down the path of the kernel Makefile.rules, which seemed overkill. > Could SUNW_OST_LINFO have a CDDL or comment? (I realize that perhaps it > cannot). I modeled it on the already-existing uxlib.src, which was uncommented, even after Jim's initial pass to CDDL everything. Since we don't post process these files in the _msg build, I would actually need to check with the g11n folks to see how they use these. Please speak up if you think that would be worthwhile. Either way, thank you for the review. --Mark _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
