I've posted some of those changes already in may

        http://mail.opensolaris.org/pipermail/tools-discuss/2009-May/004565.html

The fix for

        6412893 SUNWonbld should install into /opt/SUNWonbld

met strong opposition and thus is omitted this time.

Another one got several positive comments

        6414833 SUNWonbld should use /opt as BASEDIR

but was omitted since my sponsor Pete Dennis and Mark J. Nelson suggested
that this will have to be reworked for IPS anyway (there are no pre- and
postinstall scripts anymore, and, despite

        1 relocatable packages need to support a BASEDIR-like mechanism

IPS hasn't a BASEDIR equivalent at the moment).

Instead, two fixes to cw were adding, which makes for the following set:

        6663229 cw enters infinite loop if fork failed
        6663216 cw(1) incorrectly refers to SOS10
        6414843 SUNWonbld shouldn't install sgml man pages
        6414845 groff reports warnings in SUNWonbld man pages

The webrev is at

        http://cr.opensolaris.org/~rorth/onbld.minimal/

The fix to cw was tested with a shared object built from the following
code:

#include <sys/types.h>
#include <unistd.h>
#include <errno.h>

pid_t
fork(void)
{
        errno = EAGAIN;
        return (pid_t)-1;
}

and loaded with LD_PRELOAD.

Three questions:

* Is it important to split the two cw changes into their own changeset or
  can the wad be committed as a whole?

* Since I had noted that $SRC/tools/SUNWonbld/prototype_com wasn't properly
  sorted, as it is supposed to be, I've fixed this at the same time.  Ok or
  better omitted/split off?

* The wad contains several unrelated fixes for typos.  There are no CRs for
  those, which I hope is ok.

Comments?

        Rainer

-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to