On Thu 08 Oct 2009 at 01:33PM, Edward Pilatowicz wrote:
> On Mon, Oct 05, 2009 at 11:18:27AM -0700, Danek Duvall wrote:
> > Edward Pilatowicz wrote:
> >
> > > http://cr.opensolaris.org/~edp/onnv-webrev/
> >
> > This looks fine to me, but I may be missing other pieces
> >
> > A couple of nits:
> >
> > - line 2971: please use double-brackets here, and skip the quotes around
> > $PP, to match the other tests.
> >
> > - line 2971: I'd probably say "copied from" and make 2974 match with
> > "renamed from". Maybe make lines 3401 and 3403, match, too.
> >
>
> done.
> thanks.
> ed
Looks ok to me.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
