In addition to the visible recipients, this note was blind copied to:
- Sun internal gatekeepers
- two Sun-internal on-ips aliases
- pkg-discuss, tools-discuss, and on-discuss opensolaris aliases
I apologize for the inevitable, multiple copies. Please honor
Reply-to, and consider subscribing to on-ips-...@opensolaris.org.
Howdy--
This is the first round code review request for transitioning ON to
stop producing SVr4 packages and start producing IPS repositories. We
expect to see some amount of touch-up work while this review is
outstanding, and we will send a followup review with those changes,
and any that we make in response to code review comments.
I will be out of town and unreachable from now until Tuesday morning.
I expect that we (as a team) will accumulate responses over that
period of time, and go through them together early next week. So
don't be alarmed if you don't get immediate response from one of
us--we still value your input (and are, in fact, somewhat desperate
for it.)
The goal for this integration is for ON to natively build and deliver
a package set identical to that produced by the OpenSolaris importer.
To that end, please focus your review primarily on that issue. If you
object to what those deliveries, you may certainly note it, but this
code review thread is not the forum where it will get the most
appropriate attention.
In your reply, it will be tremendously helpful if you clearly identify
each of your issues (initials and item number would be great), and if
you make sure to let us know what code you have reviewed, even if you
don't have any comments on it. You get bonus points for prioritizing
or categorizing feedback (must fix, file a followup bug, please comment,
typo, cosmetic, etc.)
The bulk of the code changes can be found in usr/src/pkg and
usr/src/tools. In reviewing those, it will be helpful if you are
familiar with pkgsend(1), pkgmogrify(1), and pkg.depotd(1M).
Notes on these:
1) Since pkgdefs is going away, acr must follow. We're still
delivering bfu, but conflict resolution will be manual. This is a
temporary state, as bfu will be phased out.
2) The material in usr/src/pkg/docs is of interest, but is not
intended for integration as-is. Some of the aforementioned change
is around documentation. So, while you might want to read that if
you're not yet familiar with this project, it's not worth a ton of
time providing corrections.
3) We know that the archive_build script is ad hoc and does not belong
in SUNWonbld. Since it's been useful for, and maintained by, more
than one of us, it's still in our project gate. But it will go
away prior to integration.
http://cr.opensolaris.org/~mjnelson/webrev.on-ips-pkg/
http://cr.opensolaris.org/~mjnelson/webrev.on-ips-tools/
The manifests will be of interest in helping understand how we will be
packaging software, but it's probably not worthwhile to dwell on their
correctness. The ultimate arbiter of this will be pkgdiffs against the
OpenSolaris imported build 133.
http://cr.opensolaris.org/~mjnelson/webrev.on-ips-manifests/
The remaining interesting changes scattered throughout the source tree
can be found here:
http://cr.opensolaris.org/~mjnelson/webrev.on-ips-catchall/
...and finally, the pkgdefs webrev merely shows that I moved the
necessary files out of pkgdefs into other parts of the tree, and then
did "hg rm usr/src/pkgdefs" in our project workspace:
http://cr.opensolaris.org/~mjnelson/webrev.on-ips-pkgdefs/
--Mark, on behalf of the ON IPS transition team
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
