> usr/src/Makefile:
> - Won't this cause stand to build twice on sparc (once as a dependency 
> of psm and once because it's listed in sparc_SUBDIRS)? The second time 
> should be a nop, but still unnecessary, right?

No.  We were previously relying on the implicit behavior of dmake to
evaluate dependencies in the specified order, but we were listing psm in
both sparc_ and i386_ subdirs to get the order correct.

Specifying the dependency makes that explicit, and will work correctly
even if SUBDIRS are built in parallel.  But the rule for the stand
target will only be executed once.

> usr/src/pkg/Makefile:
> - What's the advantage of having install depend on $(ALL_TARGETS) 
> instead of all?

In this case, none, really.  In general, targets that don't correspond
to actual files will be rebuilt when they don't exist.  So if you had

        all: dep1
                fu

        installA: dep1
                bar

        installB: all
                whee

and you did "make all," then a subsequent "make installA" would execute
only "bar," but a "make installB" would execute "fu" and "whee."

That's a longwinded way to say "trying to practice good makefile
hygiene, even when it doesn't actually make a difference."

--Mark

_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to