Is there a canonical location/version for webrev? Webrev used to work for me, but at some point it stopped working. It is possible that happened when I upgraded from Fedora 13 to 14. The problem is that that the top-level index.html doesn't have the correct output - for an example, see: http://per.bothner.com/tmp/bad-webrev/index.html
I chased it down to this line (see the attached patch): exec 1<&- # Close stdout. Interestingly, when trying to track this down, I wrote test-script - the "exec dance" (including above line) worked fine when using bash, but not when using /bin/ksh. It's possible I have a bad version of /bin/ksh, but since the close doesn't seem to be needed, might as well remove it. -- --Per Bothner per.both...@oracle.com p...@bothner.com http://per.bothner.com/
--- webrev~ 2011-01-27 12:09:15.407255441 -0800 +++ webrev 2011-02-03 16:15:40.484224577 -0800 @@ -2892,7 +2892,6 @@ print " index.html: \c" INDEXFILE=$WDIR/index.html exec 3<&1 # duplicate stdout to FD3. -exec 1<&- # Close stdout. exec > $INDEXFILE # Open stdout to index file. print "$HTML<head>"
_______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org