#15852: Remove/synchronize Torbutton SOCKS pref logic -------------------------------------------------+------------------------- Reporter: mikeperry | Owner: brade Type: defect | Status: | needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-4.5-regression, tbb-torbutton- | Actual Points: conversion, TorBrowserTeam201608R | Parent ID: | Points: Reviewer: | Sponsor: | SponsorU -------------------------------------------------+-------------------------
Comment (by mcs): Replying to [comment:12 gk]: > commit 573bb7fb3b22cfc28d3dce01e2378d1b181e6d43 looks good. > > re commit 6244aadf7cfd944e8b53aabd1da52fe40df89f96: > > 1) It seems we don't need to add/remove an observer for `network.proxy` anymore in torbutton,js? You are right. We will remove that observer. > 2) Maybe add `3. Reset Security Slider settings" in `torbutton_prefs_reset_defaults()`? OK. > 3) I have the feeling that > {{{ > // XXX: Hack for TBB people who alternate between transproxy and non > }}} > in `startup-observer.js` can go as well or did I miss something? Do you mean just remove the comment or do you want the code to be removed? Kathy and I thought we should keep the code so that existing behavior is not modified for users who rely on setting the env variables. Thanks for reviewing all of this! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15852#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs