#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
| arthuredelstein
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-torbutton-conversion, | Actual Points:
TorBrowserTeam201609R |
Parent ID: | Points:
Reviewer: | Sponsor:
| SponsorU
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:10 arthuredelstein]:
> Replying to [comment:9 gk]:
> > Just two quick questions regarding the Torbutton patch:
> >
> > 1) You remove the defense against an OS maximizing the window on
start-up because it thinks the browser window is taking more space on the
screen than a particular threshold determines (this happened with Ubuntu
Unity on displays with low resolution IIRC). Is that a non-issue anymore?
(was fixed in #7255)
>
> Good question. I'm not certain, but I'm inclined to think that this
issue was caused by the Firefox code, here:
> https://gitweb.torproject.org/tor-
browser.git/tree/browser/base/content/browser.js?h=tor-
browser-45.3.0esr-6.5-1#n1012
>
> This patch prevents that maximization case from running entirely when
the "privacy.resistFingerprinting" pref is enabled.
>
> (In the latest versions of mozilla-central, the maximization case was
removed, which is why I am linked to the tor-browser repo instead.)
Interested. I'll double-check that but I think the case I have in mind is
the underlying OS causing this.
> > 2) You remove the option to customize the maxWidth and maxHeight. Do
you think this is not necessary anymore as it was originally used for
users that ran into corner cases we fixed? If so, I wonder whether it
would be smart to keep those prefs and checks anyway to allow users a
better option than to maximize.
>
> Yes, we can add that option to the browser patch, although I think we
should always round the window size when fingerprinting resistance is
enabled. Here's a new version:
>
> https://github.com/arthuredelstein/tor-browser/commit/19459+6
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
