#20070: Make address choice failure log message more informative
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  CoreTorTeam201609, ipv6, review-     |  Actual Points:  0.2
  group-9                                        |
Parent ID:                                       |         Points:  0.2
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:6 dgoulet]:
 > Quick questions. Only ipv6, not v4?
 >
 > {{{
 > +    /* If an authority or fallback directory has a hard-coded IPv6
 address,
 > +     * but we receive a descriptor without that address, Tor will
 believe the
 > +     * descriptor, and end up here. */
 > }}}

 IPv4 addresses are mandatory: they can be different between hard-coded
 details and descriptor, but they can't be missing in the descriptor or
 hard-coded details, so this case does not apply. (We might get a
 reachability mismatch if the IPv4 addresses aren't the same, I guess that
 would send us here also. I'll revise the comment.)

 {{{
 +    /* If an authority or fallback directory has:
 +     * - a hard-coded IPv4 address, but we receive a descriptor with a
 different address, or
 +     * - a hard-coded IPv6 address, but we receive a descriptor without
 that address,
 +     * Tor can find no reachable relays in the consensus, try a fallback
 (or authority)
 +     * on its hard-coded address, but ultimately believe the descriptor,
 and end up here. */
 }}}

 > Also, why don't we backtrace in the case of the hard-coded rs?

 Because it's not an unexpected situation (it's entirely normal when a
 fallback drops its IPv6 address) and backtraces alarm users.

 > Else lgtm; Feel free to `merge_ready` this if the you believe my
 questions don't need code modification.
 >
 > actual-review-points: 0.1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20070#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to