#18357: HiddenServicePort IPv6 broken
 Reporter:  sega01                         |          Owner:  nickm
     Type:  defect                         |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.2.9.x-final
Component:  Core Tor/Tor                   |        Version:  Tor:
 Severity:  Normal                         |     Resolution:
 Keywords:  ipv6, tor-hs, review-group-10  |  Actual Points:  .1
Parent ID:                                 |         Points:  0.5
 Reviewer:                                 |        Sponsor:  SponsorR-can

Comment (by asn):

 Just tested this patch and it seems to work!

 That is, with master I could not connect to an HS that was pointing to
 `[::1]:80`, but when I used nick's branch it worked fine. An HS pointing
 to `` worked fine in both cases.

 Some nitpicking: I kind of feel like this exit policy matching thing
 deserves its own function. And the chutney tests (or even unittests) that
 teor suggested would be a nice addition I guess.

 Other than those metacomments above, the branch seems to work fine. Feel
 free to toggle `merge_ready`.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18357#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
tor-bugs mailing list

Reply via email to