#20373: Privacy and Security Settings window opens twice -------------------------------------------------+------------------------- Reporter: arthuredelstein | Owner: tbb- | team Type: defect | Status: closed Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Minor | Resolution: fixed Keywords: tbb-usability, | Actual Points: TorBrowserTeam201610R | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by arthuredelstein): Replying to [comment:4 mcs]: > I know this is a late comment (and the patch looks OK to me), but rather than tracking open windows inside Torbutton I would have used nsIWindowMediator.getMostRecentWindow() to find the dialog if it is open (we would need to add a unique type attribute to the dialog XUL). Or maybe there is a reason why that approach would not work in this situation. I think you're right that this approach would likely work, too. I hadn't thought of using it. If you or gk would prefer I can add a follow-on patch. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20373#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs